Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2880913002: Revert of DevTools: render product badges behind the setting. (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: render product badges behind the setting. (patchset #6 id:100001 of https://codereview.chromium.org/2879943003/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 471581 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBiYjk2ZmFjMTY3YjUyNjZlNTZiNzYzOGNmZTFhMzVhOGY3ZmE0ODgM Original issue's description: > DevTools: render product badges behind the setting. > > Review-Url: https://codereview.chromium.org/2879943003 > Cr-Commit-Position: refs/heads/master@{#471581} > Committed: https://chromium.googlesource.com/chromium/src/+/0bb96fac167b5266e56b7638cfe1a35a8f7fa488 TBR=dgozman@chromium.org,allada@chromium.org,alph@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2880913002 Cr-Commit-Position: refs/heads/master@{#471583} Committed: https://chromium.googlesource.com/chromium/src/+/6d4cf0412f4b416534eb882b435b90111cfbabed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -313 lines) Patch
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/quick-open/command-menu-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Color.js View 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 chunk +67 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js View 1 chunk +0 lines, -156 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/product_registry/badge.css View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/product_registry/module.json View 1 chunk +1 line, -24 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/product_registry/popup.css View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
findit-for-me
Created Revert of DevTools: render product badges behind the setting.
3 years, 7 months ago (2017-05-13 08:48:04 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 7 months ago (2017-05-13 08:48:06 UTC) #3
hans
lgtm
3 years, 7 months ago (2017-05-13 15:55:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880913002/1
3 years, 7 months ago (2017-05-13 15:56:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6d4cf0412f4b416534eb882b435b90111cfbabed
3 years, 7 months ago (2017-05-13 15:56:59 UTC) #10
paulirish
3 years, 7 months ago (2017-05-13 18:15:10 UTC) #11
Message was sent while issue was closed.
The compile failure:

FAILED: gen/devtools/devtools_resources.grd 
python
../../third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py 
{......} --output gen/devtools/devtools_resources.grd
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py",
line 169, in <module>
    sys.exit(main(sys.argv))
  File
"../../third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py",
line 154, in main
    shutil.copy(filename, target_dir)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
line 119, in copy
    copyfile(src, dst)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
line 82, in copyfile
    with open(src, 'rb') as fsrc:

IOError: [Errno 2] No such file or directory:
'resources/inspector/product_registry/product_registry_module.js'

Powered by Google App Engine
This is Rietveld 408576698