Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2880873002: rename PerformanceServerTiming members to conform with 'Blink Rename' (Closed)

Created:
3 years, 7 months ago by cvazac-akam
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, panicker+watch_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

rename PerformanceServerTiming members to conform with 'Blink Rename' BUG=675877 Review-Url: https://codereview.chromium.org/2880873002 Cr-Commit-Position: refs/heads/master@{#471586} Committed: https://chromium.googlesource.com/chromium/src/+/de0ad0210a83a3c2bf721f561b4a1df76ff55e10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/timing/PerformanceServerTiming.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
cvazac-akam
3 years, 7 months ago (2017-05-13 00:44:28 UTC) #3
Nico
On 2017/05/13 00:44:28, cvazac-akam wrote: Lgtm, thanks! Please add BUG=675877 to the cl description.
3 years, 7 months ago (2017-05-13 01:05:05 UTC) #4
cvazac-akam
I know about blink_rename_merge_helper, but is there a tool that I can run against local ...
3 years, 7 months ago (2017-05-13 01:18:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880873002/1
3 years, 7 months ago (2017-05-13 02:13:06 UTC) #8
Nico
On 2017/05/13 01:18:38, cvazac-akam wrote: > I know about blink_rename_merge_helper, but is there a tool ...
3 years, 7 months ago (2017-05-13 02:13:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/370038)
3 years, 7 months ago (2017-05-13 03:21:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880873002/1
3 years, 7 months ago (2017-05-13 13:12:18 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 16:48:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de0ad0210a83a3c2bf721f561b4a...

Powered by Google App Engine
This is Rietveld 408576698