Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2880853002: Reports host version, host os and host os version for It2me Host. (Closed)

Created:
3 years, 7 months ago by kelvinp
Modified:
3 years, 7 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reports host version, host os and host os version for It2me Host. This change is backward compatible with the existing deployed backend services as they will simply ignore the unrecognized fields. BUG=721915 Review-Url: https://codereview.chromium.org/2880853002 Cr-Commit-Position: refs/heads/master@{#471962} Committed: https://chromium.googlesource.com/chromium/src/+/63e2b3c73a2be03b588f73b80f45bb1141133ade

Patch Set 1 #

Patch Set 2 : Fix Unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M remoting/host/it2me/it2me_host_unittest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M remoting/host/register_support_host_request.cc View 3 chunks +30 lines, -4 lines 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kelvinp
PTAL
3 years, 7 months ago (2017-05-12 21:52:05 UTC) #2
joedow
lgtm
3 years, 7 months ago (2017-05-12 22:12:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880853002/1
3 years, 7 months ago (2017-05-13 02:29:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/453783)
3 years, 7 months ago (2017-05-13 02:40:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880853002/40001
3 years, 7 months ago (2017-05-15 23:44:43 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 00:58:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/63e2b3c73a2be03b588f73b80f45...

Powered by Google App Engine
This is Rietveld 408576698