Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2880803002: [ios clean] Toolbar UI improvements. (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
Reviewers:
edchin
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Toolbar UI improvements. -Changes the ToolbarUI so it looks like the old toolbar. -Button area is now bigger, just like the old toolbar. -Some ToolbarButton refactoring. SS: https://drive.google.com/open?id=0Byo6-Nuda2jgdjVXbmZZenVMeUU BUG=683793 Review-Url: https://codereview.chromium.org/2880803002 Cr-Commit-Position: refs/heads/master@{#472333} Committed: https://chromium.googlesource.com/chromium/src/+/1d8a54dd537bdf375940f7698f3c34d1326b9951

Patch Set 1 #

Patch Set 2 : Creates ToolbarConstants file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -25 lines) Patch
M ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_button.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.mm View 7 chunks +35 lines, -8 lines 0 comments Download
A ios/clean/chrome/browser/ui/toolbar/toolbar_constants.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm View 1 4 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sczs
Ed, PTAL.
3 years, 7 months ago (2017-05-12 19:19:54 UTC) #4
edchin
lgtm
3 years, 7 months ago (2017-05-17 00:20:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880803002/1
3 years, 7 months ago (2017-05-17 00:21:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/97642) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-17 00:37:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880803002/20001
3 years, 7 months ago (2017-05-17 01:52:07 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:05:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d8a54dd537bdf375940f7698f3c...

Powered by Google App Engine
This is Rietveld 408576698