[Device Service] Add ACCELEROMETER implementation on Mac to //device/generic_sensor

[Device Service] Add ACCELEROMETER implementation on Mac to //device/generic_sensor

At //device/sensors, DeviceOrientation Event is implemented on Mac using
sudden motion sensor, and it is a kind of ACCELEROMETER. And
//device/generic_sensor has ACCELEROMETER sensor type, but the Mac
implementation is missing. In order to make //content/renderer/device_sensors
depend on //device/generic_sensor instead of //device/sensors, this CL adds
ACCELEROMETER sensor implementation to //device/generic_sensor on Mac.

BUG=721427, 718460
Review-Url: https://codereview.chromium.org/2880743003
Cr-Commit-Position: refs/heads/master@{#471567}
Committed: https://chromium.googlesource.com/chromium/src/+/94de540ef9694dd6d2680dc6da1375e982d7577e

[juncai, 2017-05-13 00:19:53]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 00:20:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-05-13 00:23:29]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org

[juncai, 2017-05-13 00:23:29]

Please take a look.

[Reilly Grant (use Gerrit), 2017-05-13 00:33:16]

lgtm with nits

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_accelerometer_mac.cc (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.cc:62: return
default_configuration;
return PlatformSensorConfiguration(kDefaultAccelerometerFrequencyHz);

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_accelerometer_mac.h (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.h:17: // Implementation
of PlatformSensor for MacOS to query the accelerometer
MacOS -> macOS

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.h:25: // to write the
result back.
Construct a platform sensor of type ACCELEROMETER, given a buffer |mapping|
where readings will be written.

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_provider_mac.cc (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_provider_mac.cc:39:
callback.Run(std::move(sensor));
callback.Run(base::MakeShared<PlatformSensorAccelerometerMac>(std::move(mapping),
this));

[juncai, 2017-05-13 00:50:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 00:50:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-05-13 00:53:48]

juncai@chromium.org changed reviewers:
+ avi@chromium.org

[juncai, 2017-05-13 00:53:49]

avi@chromium.org: Please review changes in //device/generic_sensor/DEPS that
adds '+third_party/sudden_motion_sensor'

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_accelerometer_mac.cc (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.cc:62: return
default_configuration;
On 2017/05/13 00:33:16, Reilly Grant wrote:
> return PlatformSensorConfiguration(kDefaultAccelerometerFrequencyHz);

Done.

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_accelerometer_mac.h (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.h:17: // Implementation
of PlatformSensor for MacOS to query the accelerometer
On 2017/05/13 00:33:16, Reilly Grant wrote:
> MacOS -> macOS

Done.

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_accelerometer_mac.h:25: // to write the
result back.
On 2017/05/13 00:33:16, Reilly Grant wrote:
> Construct a platform sensor of type ACCELEROMETER, given a buffer |mapping|
> where readings will be written.

Done.

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
File device/generic_sensor/platform_sensor_provider_mac.cc (right):

https://codereview.chromium.org/2880743003/diff/1/device/generic_sensor/platf...
device/generic_sensor/platform_sensor_provider_mac.cc:39:
callback.Run(std::move(sensor));
On 2017/05/13 00:33:16, Reilly Grant wrote:
>
callback.Run(base::MakeShared<PlatformSensorAccelerometerMac>(std::move(mapping),
> this));

Done.

[commit-bot: I haz the power, 2017-05-13 02:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:51:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-05-13 04:20:56]

lgtm

[juncai, 2017-05-13 04:23:24]

The CQ bit was checked by juncai@chromium.org

[juncai, 2017-05-13 04:23:24]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2880743003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-05-13 04:23:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 05:45:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494649404480790,
"parent_rev": "44a4480c96442d8d466e958b7260775a4cf30a5b", "commit_rev":
"94de540ef9694dd6d2680dc6da1375e982d7577e"}

[commit-bot: I haz the power, 2017-05-13 05:45:52]

Description was changed from

==========
[Device Service] Add ACCELEROMETER implementation on Mac to
//device/generic_sensor

At //device/sensors, DeviceOrientation Event is implemented on Mac using
sudden motion sensor, and it is a kind of ACCELEROMETER. And
//device/generic_sensor has ACCELEROMETER sensor type, but the Mac
implementation is missing. In order to make //content/renderer/device_sensors
depend on //device/generic_sensor instead of //device/sensors, this CL adds
ACCELEROMETER sensor implementation to //device/generic_sensor on Mac.

BUG=721427, 718460
==========

to

==========
[Device Service] Add ACCELEROMETER implementation on Mac to
//device/generic_sensor

At //device/sensors, DeviceOrientation Event is implemented on Mac using
sudden motion sensor, and it is a kind of ACCELEROMETER. And
//device/generic_sensor has ACCELEROMETER sensor type, but the Mac
implementation is missing. In order to make //content/renderer/device_sensors
depend on //device/generic_sensor instead of //device/sensors, this CL adds
ACCELEROMETER sensor implementation to //device/generic_sensor on Mac.

BUG=721427, 718460

Review-Url: https://codereview.chromium.org/2880743003
Cr-Commit-Position: refs/heads/master@{#471567}
Committed:
https://chromium.googlesource.com/chromium/src/+/94de540ef9694dd6d2680dc6da13...
==========

[commit-bot: I haz the power, 2017-05-13 05:45:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/94de540ef9694dd6d2680dc6da13...