Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext] (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
index f75b6e7981dc25ef4d73f3b08e595250f4157882..18a37fffd00bcefbb153b67bf38e5f51a2e1fc09 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
@@ -50,10 +50,7 @@ void InstallConditionalFeaturesForModules(
v8::Isolate* isolate = script_state->GetIsolate();
const DOMWrapperWorld& world = script_state->World();
if (wrapper_type_info == &V8Navigator::wrapperTypeInfo) {
- // Mimics the [SecureContext] extended attribute. Work-around for
- // https://crbug.com/695123.
- if (OriginTrials::installedAppEnabled(execution_context) &&
- execution_context->IsSecureContext()) {
+ if (OriginTrials::installedAppEnabled(execution_context)) {
V8NavigatorPartial::installInstalledApp(
isolate, world, v8::Local<v8::Object>(), prototype_object,
interface_object);
@@ -63,10 +60,7 @@ void InstallConditionalFeaturesForModules(
v8::Local<v8::Object>(),
prototype_object, interface_object);
}
- // Mimics the [SecureContext] extended attribute. Work-around for
- // https://crbug.com/695123.
- if (OriginTrials::webUSBEnabled(execution_context) &&
- execution_context->IsSecureContext()) {
+ if (OriginTrials::webUSBEnabled(execution_context)) {
V8NavigatorPartial::installWebUSB(isolate, world, v8::Local<v8::Object>(),
prototype_object, interface_object);
}

Powered by Google App Engine
This is Rietveld 408576698