Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js

Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext] (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
index 60dbf45e58aea9c09a970cd47486204f17317e8f..9b58ee2f7c13d5755d16e1ba8d9e7822b1f4faf4 100644
--- a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
+++ b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
@@ -148,23 +148,18 @@ expect_always_bindings = (insecure_context, opt_description_suffix) => {
}, 'Constant should exist on interface and return value, regardless of trial' + description_suffix);
if (insecure_context) {
- // TODO(crbug.com/695123): Uncomment test when fixed so [SecureContext] and
- // [OriginTrialEnabled] extended attributes work correctly together.
- /*
test(() => {
expect_member_fails('secureUnconditionalAttribute');
}, 'Secure attribute should not exist, regardless of trial' + description_suffix);
- */
+
test(() => {
expect_member_fails('secureStaticUnconditionalAttribute');
}, 'Secure static attribute should not exist, regardless of trial' + description_suffix);
- // TODO(crbug.com/695123): Uncomment test when fixed so [SecureContext] and
- // [OriginTrialEnabled] extended attributes work correctly together.
- /*
+
test(() => {
expect_member_fails('secureUnconditionalMethod');
}, 'Secure method should not exist, regardless of trial' + description_suffix);
- */
+
test(() => {
expect_member_fails('secureStaticUnconditionalMethod');
}, 'Secure static method should not exist, regardless of trial' + description_suffix);
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698