Display ellipsis correctly in inline blocks adjacent to floats

Display ellipsis correctly in inline blocks adjacent to floats

If we're ellipsing text in atomic inlines then its the left/right bounds of the
container that we need to test against - not the width available on the line, which
may be reduced by the presence of floats that the atomic inlines in fact ignores.
This fix is covered by passing the correct values to TryPlacingEllipsisOnAtomicInlines().

The rest of the changes are to address a a separate, but related, issue in the third
testcase in LayoutTests/fast/text/place-ellipsis-in-inline-block-adjacent-float-2.html
where we are adjusting the ellipsis too soon to make a correct comparison against
the container edge. That adjustment tells us where the ellipsis is in the line
(as opposed to where it is relative to the container's left edge) so we should defer
it until we're figuring out the offset in the text we want to place the ellipsis on.

This change also reveals an edge case where we currently struggle to decide
correctly which side of a glyph to place the ellipsis on. This shows up in the
rebaselined results and will be worked under 722043 - where we will need to figure
out if the 'partial glyph' technique can be refined to give better results for
cases where the direction of the text and the direction of the flow are different
and/or there are runs of text with different directions.


BUG=720377
Review-Url: https://codereview.chromium.org/2880653002
Cr-Commit-Position: refs/heads/master@{#473005}
Committed: https://chromium.googlesource.com/chromium/src/+/8a73c444189475c28fcb01c0d6dad6e8ec370986

[rhogan, 2017-05-11 21:30:21]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 21:31:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:09:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rhogan, 2017-05-12 16:46:13]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:46:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 19:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:18:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2017-05-13 15:50:32]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 15:50:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-05-13 15:58:27]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 15:58:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 18:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 18:07:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2017-05-16 18:09:06]

Description was changed from

==========
Display ellipsis correctly in inline blocks adjacent to floats

BUG=720377
==========

to

==========
Display ellipsis correctly in inline blocks adjacent to floats

If we're ellipsing text in atomic inlines then its the left/right bounds of the
container that we need to test against - not the width available on the line,
which
may be reduced by the presence of floats that the atomic inlines in fact
ignores.
This fix is covered by passing the correct values to
TryPlacingEllipsisOnAtomicInlines().

The rest of the changes are to address a a separate, but related, issue in the
third
testcase in
LayoutTests/fast/text/place-ellipsis-in-inline-block-adjacent-float-2.html
where we are adjusting the ellipsis too soon to make a correct comparison
against
the container edge. That adjustment tells us where the ellipsis is in the line
(as opposed to where it is relative to the container's left edge) so we should
defer
it until we're figuring out the offset in the text we want to place the ellipsis
on.

This change also reveals an edge case where we currently struggle to decide
correctly which side of a glyph to place the ellipsis on. This shows up in the
rebaselined results and will be worked under 722043 - where we will need to
figure
out if the 'partial glyph' technique can be refined to give better results for
cases where the direction of the text and the direction of the flow are
different
and/or there are runs of text with different directions.


BUG=720377
==========

[rhogan, 2017-05-16 18:10:01]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[eae, 2017-05-16 18:45:55]

Thank you, LGTM

[rhogan, 2017-05-18 19:13:31]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2017-05-18 19:13:31]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2880653002/#ps60001
(title: "bug 720377")

[commit-bot: I haz the power, 2017-05-18 19:14:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 01:07:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495134811327760,
"parent_rev": "3a6a7eb394e0c06f7789a98b6c15bba2a9f84012", "commit_rev":
"8a73c444189475c28fcb01c0d6dad6e8ec370986"}

[commit-bot: I haz the power, 2017-05-19 01:07:42]

Description was changed from

==========
Display ellipsis correctly in inline blocks adjacent to floats

If we're ellipsing text in atomic inlines then its the left/right bounds of the
container that we need to test against - not the width available on the line,
which
may be reduced by the presence of floats that the atomic inlines in fact
ignores.
This fix is covered by passing the correct values to
TryPlacingEllipsisOnAtomicInlines().

The rest of the changes are to address a a separate, but related, issue in the
third
testcase in
LayoutTests/fast/text/place-ellipsis-in-inline-block-adjacent-float-2.html
where we are adjusting the ellipsis too soon to make a correct comparison
against
the container edge. That adjustment tells us where the ellipsis is in the line
(as opposed to where it is relative to the container's left edge) so we should
defer
it until we're figuring out the offset in the text we want to place the ellipsis
on.

This change also reveals an edge case where we currently struggle to decide
correctly which side of a glyph to place the ellipsis on. This shows up in the
rebaselined results and will be worked under 722043 - where we will need to
figure
out if the 'partial glyph' technique can be refined to give better results for
cases where the direction of the text and the direction of the flow are
different
and/or there are runs of text with different directions.


BUG=720377
==========

to

==========
Display ellipsis correctly in inline blocks adjacent to floats

If we're ellipsing text in atomic inlines then its the left/right bounds of the
container that we need to test against - not the width available on the line,
which
may be reduced by the presence of floats that the atomic inlines in fact
ignores.
This fix is covered by passing the correct values to
TryPlacingEllipsisOnAtomicInlines().

The rest of the changes are to address a a separate, but related, issue in the
third
testcase in
LayoutTests/fast/text/place-ellipsis-in-inline-block-adjacent-float-2.html
where we are adjusting the ellipsis too soon to make a correct comparison
against
the container edge. That adjustment tells us where the ellipsis is in the line
(as opposed to where it is relative to the container's left edge) so we should
defer
it until we're figuring out the offset in the text we want to place the ellipsis
on.

This change also reveals an edge case where we currently struggle to decide
correctly which side of a glyph to place the ellipsis on. This shows up in the
rebaselined results and will be worked under 722043 - where we will need to
figure
out if the 'partial glyph' technique can be refined to give better results for
cases where the direction of the text and the direction of the flow are
different
and/or there are runs of text with different directions.


BUG=720377

Review-Url: https://codereview.chromium.org/2880653002
Cr-Commit-Position: refs/heads/master@{#473005}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a73c444189475c28fcb01c0d6da...
==========

[commit-bot: I haz the power, 2017-05-19 01:07:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a73c444189475c28fcb01c0d6da...