Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2880613003: Enable BookmarkBarViewTest on official bots. (Closed)

Created:
3 years, 7 months ago by Alexander Alekseev
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable BookmarkBarViewTest on official bots. This test has been disabled until 431450 is fixed. This happened long ago, so we probably can re-enable it. BUG=431450 Review-Url: https://codereview.chromium.org/2880613003 Cr-Commit-Position: refs/heads/master@{#471531} Committed: https://chromium.googlesource.com/chromium/src/+/1585fc7d5b1d7bed346e1dd0eaa37094918f9289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Alexander Alekseev
I came across a disabled test, which should probably be enabled (as you fixed the ...
3 years, 7 months ago (2017-05-12 23:26:56 UTC) #8
oshima
lgtm thank you for finding it!
3 years, 7 months ago (2017-05-13 01:11:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880613003/1
3 years, 7 months ago (2017-05-13 01:21:05 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 01:26:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1585fc7d5b1d7bed346e1dd0eaa3...

Powered by Google App Engine
This is Rietveld 408576698