Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2880593002:
DevTools: Add CSS Box Alignment properties to CSSMetadata.js (Closed)
|
Created:
3 years, 7 months ago by Manuel Rego Modified:
3 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Add CSS Box Alignment properties to CSSMetadata.js
The list of properties from the spec:
https://drafts.csswg.org/css-align/#property-index
BUG=714069
Review-Url: https://codereview.chromium.org/2880593002
Cr-Commit-Position: refs/heads/master@{#471278}
Committed: https://chromium.googlesource.com/chromium/src/+/f2125fea63367c21af67cddccb5ba50d9309070d
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
rego@igalia.com changed reviewers: + dgozman@chromium.org, lushnikov@chromium.org, pfeldman@chromium.org
And one more so Grid Layout and alignment will be covered. Thanks!
lgtm
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494589608833790, "parent_rev":
"a377e3e1fa4f44a58f70abb2402e6cc79e210945", "commit_rev":
"f2125fea63367c21af67cddccb5ba50d9309070d"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add CSS Box Alignment properties to CSSMetadata.js The list of properties from the spec: https://drafts.csswg.org/css-align/#property-index BUG=714069 ========== to ========== DevTools: Add CSS Box Alignment properties to CSSMetadata.js The list of properties from the spec: https://drafts.csswg.org/css-align/#property-index BUG=714069 Review-Url: https://codereview.chromium.org/2880593002 Cr-Commit-Position: refs/heads/master@{#471278} Committed: https://chromium.googlesource.com/chromium/src/+/f2125fea63367c21af67cddccb5b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f2125fea63367c21af67cddccb5b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
