Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2880583002: Revert of Refined DCHECK preventing multiple event forwarders in VA tree path (Closed)

Created:
3 years, 7 months ago by sebsg
Modified:
3 years, 7 months ago
Reviewers:
Jinsuk Kim, boliu
CC:
chromium-reviews, mthiesse
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refined DCHECK preventing multiple event forwarders in VA tree path (patchset #9 id:200001 of https://codereview.chromium.org/2861413002/ ) Reason for revert: Primary suspect making ViewAndroidTest.ChecksMultipleEventForwarders fails consistently https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests Original issue's description: > Refined DCHECK preventing multiple event forwarders in VA tree path > > A ViewAndroid tree path from the top to a leaf node can have only > a single EventForwarder instance. Rewrote helper methods used for > DCHECK that enforces the requirement to match the actual job with > the intention. > > BUG=717271 > > Review-Url: https://codereview.chromium.org/2861413002 > Cr-Commit-Position: refs/heads/master@{#470814} > Committed: https://chromium.googlesource.com/chromium/src/+/1a116ecfdf829702b653ded84a0e1cdb8bdfd7d6 TBR=boliu@chromium.org,jinsukkim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717271 Review-Url: https://codereview.chromium.org/2880583002 Cr-Commit-Position: refs/heads/master@{#470938} Committed: https://chromium.googlesource.com/chromium/src/+/38ac4c9a36f237bcddf1ae1e723a7ee00c841f64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -53 lines) Patch
M ui/android/view_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/android/view_android.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M ui/android/view_android_unittests.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sebsg
Created Revert of Refined DCHECK preventing multiple event forwarders in VA tree path
3 years, 7 months ago (2017-05-11 13:20:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880583002/1
3 years, 7 months ago (2017-05-11 13:20:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 13:21:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38ac4c9a36f237bcddf1ae1e723a...

Powered by Google App Engine
This is Rietveld 408576698