Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2880573003: Remove PaintImage trace from KnownToBeOpaque in StyleFetchedImage (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PaintImage trace from KnownToBeOpaque in StyleFetchedImage Remove obsolete PaintImage trace from StyleFetchedImage::KnownToBeOpaque and StyleFetchedImageSet::KnownToBeOpaque. Trace was originally added in late 2014 (in r186030) to the ImageResource::currentFrameKnownToBeOpaque method as it, at the time, caused a forced decode for the image. That is no longer the case yet the trace call has stubbornly survived unchanged. R=pdr@chromium.org Review-Url: https://codereview.chromium.org/2880573003 Cr-Commit-Position: refs/heads/master@{#471089} Committed: https://chromium.googlesource.com/chromium/src/+/df9f27f551ca5f0686aea37ed459a03b35a7c9b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
eae
3 years, 7 months ago (2017-05-11 18:31:44 UTC) #1
pdr.
On 2017/05/11 at 18:31:44, eae wrote: > LGTM
3 years, 7 months ago (2017-05-11 19:50:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880573003/1
3 years, 7 months ago (2017-05-11 20:48:06 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:26:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df9f27f551ca5f0686aea37ed459...

Powered by Google App Engine
This is Rietveld 408576698