Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3085)

Unified Diff: chrome/browser/media/webrtc/media_stream_device_permission_context.cc

Issue 2880503002: Block insecure pepper requests (Closed)
Patch Set: Block insecure pepper requests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/media_stream_device_permission_context.cc
diff --git a/chrome/browser/media/webrtc/media_stream_device_permission_context.cc b/chrome/browser/media/webrtc/media_stream_device_permission_context.cc
index 121e268e3b75e137cbf7f95bd23484b1d7718749..d31aeda3480524c419ac42e59b69d1b52906f45c 100644
--- a/chrome/browser/media/webrtc/media_stream_device_permission_context.cc
+++ b/chrome/browser/media/webrtc/media_stream_device_permission_context.cc
@@ -10,6 +10,7 @@
#include "chrome/common/pref_names.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/content_settings.h"
+#include "content/public/common/content_features.h"
#include "content/public/common/url_constants.h"
#include "extensions/common/constants.h"
@@ -91,8 +92,6 @@ void MediaStreamDevicePermissionContext::CancelPermissionRequest(
}
bool MediaStreamDevicePermissionContext::IsRestrictedToSecureOrigins() const {
- // Flash currently doesn't require secure origin to use mic/camera. If we
- // return true here, it'll break the use case like http://tinychat.com.
- // TODO(raymes): Change this to true after crbug.com/526324 is fixed.
- return false;
+ return base::FeatureList::IsEnabled(
+ features::kRequireSecureOriginsForPepperMediaRequests);
}
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698