Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2880493002:
DevTools: More precise CPU throttling rate on Linux (Closed)
DescriptionDevTools: More precise CPU throttling rate on Linux
There seems to be some delay during POSIX signal propagation
to the target thread.
Move the run/sleep logic to the signal handler and make it adaptive.
BUG=720093
Review-Url: https://codereview.chromium.org/2880493002
Cr-Commit-Position: refs/heads/master@{#470790}
Committed: https://chromium.googlesource.com/chromium/src/+/df33f5f39300a46b43eefb4f8940fac99b37b491
Patch Set 1 #Patch Set 2 : fix Mac build #Patch Set 3 : ю #Messages
Total messages: 20 (11 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org
lgtm
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2880493002/#ps20001 (title: "fix Mac build")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2880493002/#ps40001 (title: "ю")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494463763502410,
"parent_rev": "e6ac7322836b02036f2758a16b520b00e1330cb3", "commit_rev":
"df33f5f39300a46b43eefb4f8940fac99b37b491"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: More precise CPU throttling rate on Linux There seems to be some delay during POSIX signal propagation to the target thread. Move the run/sleep logic to the signal handler and make it adaptive. BUG=720093 ========== to ========== DevTools: More precise CPU throttling rate on Linux There seems to be some delay during POSIX signal propagation to the target thread. Move the run/sleep logic to the signal handler and make it adaptive. BUG=720093 Review-Url: https://codereview.chromium.org/2880493002 Cr-Commit-Position: refs/heads/master@{#470790} Committed: https://chromium.googlesource.com/chromium/src/+/df33f5f39300a46b43eefb4f8940... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/df33f5f39300a46b43eefb4f8940... |
