Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2880443006: Generate common types into a separate library (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add missed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8934 lines, -8786 lines) Patch
M pkg/analysis_server/lib/src/plugin/notification_manager.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/request_converter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_converter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_merger.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/notification_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/protocol_test_utilities.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/request_converter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/result_converter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/result_merger_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/protocol/protocol_common.dart View 1 1 chunk +5444 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 79 chunks +3324 lines, -8754 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/utilities/analyzer_converter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/utilities/analyzer_converter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/api.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 4 chunks +31 lines, -12 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_inttest_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/tool/spec/codegen_protocol_common.dart View 1 1 chunk +53 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/from_html.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/generate_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 5 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
The second phase. The common types are now in their own library, but the server ...
3 years, 7 months ago (2017-05-12 21:53:50 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-05-12 22:08:32 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-13 15:12:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3085734ef67593db472bea6c56bdaefcc2d8b5ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698