Generate common types into a separate library

pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 
 import 'package:analyzer/src/codegen/tools.dart';
 import 'package:front_end/src/codegen/tools.dart';
 import 'package:html/dom.dart' as dom;
 import 'package:path/path.dart' as path;
@@ skipping 101 matching lines @@
       String subComparison =
           compareEqualsCode(resolvedType.valueType, 'a', 'b');
       String closure = '($valueTypeName a, $valueTypeName b) => $subComparison';
       return 'mapEqual($thisVar, $otherVar, $closure)';
     }
     throw new Exception(
         "Don't know how to compare for equality: $resolvedType");
   }
 
   /**
-   * Translate each type implied by the API to a class.
+   * Translate each of the given [types] implied by the API to a class.
    */
-  void emitClasses() {
-    List<ImpliedType> types = impliedTypes.values.toList();
-    types.sort((first, second) =>
-        capitalize(first.camelName).compareTo(capitalize(second.camelName)));
+  void emitClasses(List<ImpliedType> types) {
     for (ImpliedType impliedType in types) {
       TypeDecl type = impliedType.type;
       String dartTypeName = capitalize(impliedType.camelName);
       if (type == null) {
         writeln();
         emitEmptyObjectClass(dartTypeName, impliedType);
       } else if (type is TypeObject) {
         writeln();
         emitObjectClass(dartTypeName, type, impliedType);
       } else if (type is TypeEnum) {
@@ skipping 250 matching lines @@
       });
       writeln('}');
       String humanReadableNameString =
           literalString(impliedType.humanReadableName);
       writeln(
           'throw jsonDecoder.mismatch(jsonPath, $humanReadableNameString, json);');
     });
     writeln('}');
   }
 
+  void emitImports() {
+    writeln("import 'dart:convert' hide JsonDecoder;");
+    writeln();
+    writeln("import 'package:analyzer/src/generated/utilities_general.dart';");
+    writeln("import 'package:$packageName/protocol/protocol.dart';");
+    writeln(
+        "import 'package:$packageName/src/protocol/protocol_internal.dart';");
+    for (String uri in api.types.importUris) {
+      write("import '");
+      write(uri);
+      writeln("';");
+    }
+  }
+
   /**
    * Emit the class to encapsulate an object type.
    */
   void emitObjectClass(
       String className, TypeObject type, ImpliedType impliedType) {
     docComment(toHtmlVisitor.collectHtml(() {
       toHtmlVisitor.p(() {
         toHtmlVisitor.write(impliedType.humanReadableName);
       });
       if (impliedType.type != null) {
@@ skipping 637 matching lines @@
         }
       }
       return new FromJsonSnippet((String jsonPath, String json) =>
           'jsonDecoder.decodeUnion($jsonPath, $json, ${literalString(type.field)}, {${decoders.join(', ')}})');
     } else {
       throw new Exception("Can't convert $type from JSON");
     }
   }
 
   /**
+   * Return a list of the classes to be emitted.
+   */
+  List<ImpliedType> getClassesToEmit() {
+    List<ImpliedType> types = impliedTypes.values.where((ImpliedType type) {
+      ApiNode node = type.apiNode;
+      return !(node is TypeDefinition && node.isExternal);
+    }).toList();
+    types.sort((first, second) =>
+        capitalize(first.camelName).compareTo(capitalize(second.camelName)));
+    return types;
+  }
+
+  /**
    * True if the constructor argument for the given field should be optional.
    */
   bool isOptionalConstructorArg(String className, TypeObjectField field) {
     if (field.optional) {
       return true;
     }
     List<String> forceOptional = _optionalConstructorArguments[className];
     if (forceOptional != null && forceOptional.contains(field.name)) {
       return true;
     }
@@ skipping 59 matching lines @@
           dartType(type), (String value) => '$value.toJson()');
     } else {
       throw new Exception("Can't convert $resolvedType from JSON");
     }
   }
 
   @override
   visitApi() {
     outputHeader(year: '2017');
     writeln();
-    writeln("import 'dart:convert' hide JsonDecoder;");
-    writeln();
-    writeln("import 'package:analyzer/src/generated/utilities_general.dart';");
-    writeln("import 'package:$packageName/protocol/protocol.dart';");
-    writeln(
-        "import 'package:$packageName/src/protocol/protocol_internal.dart';");
-    emitClasses();
+    emitImports();
+    emitClasses(getClassesToEmit());
   }
 }
 
 /**
  * Container for code that can be used to translate a data type from JSON.
  */
 abstract class FromJsonCode {
   /**
    * Get the translation code in the form of a closure.
    */
@@ skipping 130 matching lines @@
 
   @override
   String get asClosure => '($type value) => ${callback('value')}';
 
   @override
   bool get isIdentity => false;
 
   @override
   String asSnippet(String value) => callback(value);
 }