Don't clear or allocate paint properties if they won't change.

Don't clear or allocate paint properties if they won't change.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2880423002
Cr-Commit-Position: refs/heads/master@{#471907}
Committed: https://chromium.googlesource.com/chromium/src/+/ba864de6c45b5a5379488e3b234474d7ca574f4e

[chrishtr, 2017-05-15 18:58:27]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-05-15 18:59:25]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't clear paint properties if they area already cleared.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-05-15 18:59:38]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2017-05-15 19:47:29]

Description was changed from

==========
Don't clear paint properties if they area already cleared.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't clear or allocate paint properties if they won't change.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-05-15 19:47:36]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 19:48:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-05-15 19:52:19]

LGTM

https://codereview.chromium.org/2880423002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2880423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1200:
CreateDomNodeBasedCompositorElementId(object));
I think avoiding ClearPaintProperties is a nice cleanup but unlikely to affect
perf. OTOH, not calling CreateDomNodeBasedCompositorElementId as much might be a
perf win (although, spv2 only).

[chrishtr, 2017-05-15 20:04:30]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-05-15 20:04:32]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:05:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 21:28:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494878672986760,
"parent_rev": "0779b4734b78b171c4ec4d141433074edb26c95e", "commit_rev":
"ba864de6c45b5a5379488e3b234474d7ca574f4e"}

[commit-bot: I haz the power, 2017-05-15 21:28:38]

Description was changed from

==========
Don't clear or allocate paint properties if they won't change.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't clear or allocate paint properties if they won't change.

BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2880423002
Cr-Commit-Position: refs/heads/master@{#471907}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba864de6c45b5a5379488e3b2344...
==========

[commit-bot: I haz the power, 2017-05-15 21:28:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba864de6c45b5a5379488e3b2344...