Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2880333002: Fix build with system opus (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system opus This changes GN config/target names to match what other GN files (e.g. for media_unittests) expect. BUG=none R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2880333002 . Cr-Commit-Position: refs/heads/master@{#471874} Committed: https://chromium.googlesource.com/chromium/src/+/e4a5df4eea186e4d11e4cd28393db1b44458640d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/linux/unbundle/opus.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-15 13:52:22 UTC) #2
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-15 18:37:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880333002/1
3 years, 7 months ago (2017-05-15 18:38:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/215203)
3 years, 7 months ago (2017-05-15 19:23:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880333002/1
3 years, 7 months ago (2017-05-15 19:28:45 UTC) #9
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-15 19:58:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4a5df4eea186e4d11e4cd28393db1b44458640d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698