Handle transformed descendants when drawing focus rings

Handle transformed descendants when drawing focus rings

Previously we use localToContainerPoint((0,0)) to calculate the offset
of a child when drawing focus rings. If the child is rotated, (0, 0)
won't be its top-left corner in container‘s coordinations.

Now use localToContainerQuad(childLocalFocusRingRect).enclosingBoundingBox().

Also updated RenderObject::absoluteFocusRingQuads() to be
transform-aware.

BUG=374168
TEST=transforms/transform-focus-ring.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175183

[Xianzhu, 2014-05-27 16:18:40]

ping...

[Xianzhu, 2014-05-29 16:34:32]

On 2014/05/27 16:18:40, Xianzhu wrote:
> ping...

ping...

[pdr., 2014-05-29 21:22:44]

I'm not very familiar with this code (nor are the other reviewers it seems).
This approach looks reasonable to me. I think we need to update the comment in
RenderObject::absoluteFocusRingQuads as well.

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:1056: void
addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
Nit: addChildFocusRingRects

[esprehn, 2014-05-29 21:37:06]

This seems alright, but I suspect that Julien is your best reviewer.

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:1254: for (RenderObject* curr =
slowFirstChild(); curr; curr = curr->nextSibling()) {
current, don't abbreviate.

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:1056: void
addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
Don't comment out argument names. Put them in the real code here.

[Xianzhu, 2014-05-29 22:12:31]

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:1254: for (RenderObject* curr =
slowFirstChild(); curr; curr = curr->nextSibling()) {
On 2014/05/29 21:37:06, esprehn wrote:
> current, don't abbreviate.

Done.

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:1056: void
addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
On 2014/05/29 21:37:06, esprehn wrote:
> Don't comment out argument names. Put them in the real code here.

Done.

https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:1056: void
addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
On 2014/05/29 21:22:44, pdr wrote:
> Nit: addChildFocusRingRects

Done.

[pdr., 2014-05-29 22:14:01]

On 2014/05/29 22:12:31, Xianzhu wrote:
>
https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
> File Source/core/rendering/RenderObject.cpp (right):
> 
>
https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
> Source/core/rendering/RenderObject.cpp:1254: for (RenderObject* curr =
> slowFirstChild(); curr; curr = curr->nextSibling()) {
> On 2014/05/29 21:37:06, esprehn wrote:
> > current, don't abbreviate.
> 
> Done.
> 
>
https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
> File Source/core/rendering/RenderObject.h (right):
> 
>
https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
> Source/core/rendering/RenderObject.h:1056: void
> addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
> additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
> On 2014/05/29 21:37:06, esprehn wrote:
> > Don't comment out argument names. Put them in the real code here.
> 
> Done.
> 
>
https://codereview.chromium.org/288013005/diff/20001/Source/core/rendering/Re...
> Source/core/rendering/RenderObject.h:1056: void
> addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /*
> additionalOffset */, const RenderLayerModelObject* /* paintContainer */);
> On 2014/05/29 21:22:44, pdr wrote:
> > Nit: addChildFocusRingRects
> 
> Done.

LGTM

[pdr., 2014-05-29 22:14:06]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-05-29 22:15:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/288013005/60001

[commit-bot: I haz the power, 2014-05-29 23:57:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6475)

[commit-bot: I haz the power, 2014-05-30 14:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 14:40:32]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[Xianzhu, 2014-05-30 17:14:25]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 17:15:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/288013005/80001

[commit-bot: I haz the power, 2014-05-30 18:31:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6534)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9664)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9967)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Xianzhu, 2014-05-30 18:35:38]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2014-05-30 19:18:04]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:18:39]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/288013005/100001

[Xianzhu, 2014-05-30 21:00:42]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2014-05-30 21:21:33]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 21:24:49]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/288013005/120001

[Xianzhu, 2014-05-30 23:36:25]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 23:37:47]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/288013005/140001

[commit-bot: I haz the power, 2014-05-31 01:16:04]

Change committed as 175183