Source/core/rendering/RenderObject.h - Issue 288013005: Handle transformed descendants when drawing focus rings

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 288013005: Handle transformed descendants when drawing focus rings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix inline-block under inline Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/rendering/RenderInline.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Antti Koivisto (koivisto@kde.org)	3 * (C) 2000 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)	5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)

6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.	6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.

7 * Copyright (C) 2009 Google Inc. All rights reserved.	7 * Copyright (C) 2009 Google Inc. All rights reserved.

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 1035 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1046 void drawDoubleBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,	1046 void drawDoubleBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,

1047 int length, BoxSide, Color, int thickness, int adjacentWidth1, int adjac entWidth2, bool antialias);	1047 int length, BoxSide, Color, int thickness, int adjacentWidth1, int adjac entWidth2, bool antialias);

1048 void drawRidgeOrGrooveBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,	1048 void drawRidgeOrGrooveBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,

1049 BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bo ol antialias);	1049 BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bo ol antialias);

1050 void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,	1050 void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,

1051 BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias);	1051 BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias);

1052	1052

1053 void paintFocusRing(PaintInfo&, const LayoutPoint&, RenderStyle*);	1053 void paintFocusRing(PaintInfo&, const LayoutPoint&, RenderStyle*);

1054 void paintOutline(PaintInfo&, const LayoutRect&);	1054 void paintOutline(PaintInfo&, const LayoutRect&);

1055 void addPDFURLRect(GraphicsContext*, const LayoutRect&);	1055 void addPDFURLRect(GraphicsContext*, const LayoutRect&);

	1056 void addChildrenFocusRingRects(Vector<IntRect>&, const LayoutPoint& /* addit ionalOffset /, const RenderLayerModelObject /* paintContainer */);
	pdr. 2014/05/29 21:22:44 Nit: addChildFocusRingRects Nit: addChildFocusRingRects esprehn 2014/05/29 21:37:06 Don't comment out argument names. Put them in the Don't comment out argument names. Put them in the real code here. Xianzhu 2014/05/29 22:12:31 Done. Show quoted text On 2014/05/29 21:37:06, esprehn wrote: > Don't comment out argument names. Put them in the real code here. Done. Xianzhu 2014/05/29 22:12:31 Done. Show quoted text On 2014/05/29 21:22:44, pdr wrote: > Nit: addChildFocusRingRects Done.
1056	1057

1057 virtual LayoutRect viewRect() const;	1058 virtual LayoutRect viewRect() const;

1058	1059

1059 void clearLayoutRootIfNeeded() const;	1060 void clearLayoutRootIfNeeded() const;

1060 virtual void willBeDestroyed();	1061 virtual void willBeDestroyed();

1061 void postDestroy();	1062 void postDestroy();

1062	1063

1063 virtual void insertedIntoTree();	1064 virtual void insertedIntoTree();

1064 virtual void willBeRemovedFromTree();	1065 virtual void willBeRemovedFromTree();

1065	1066

(...skipping 407 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1473 void showTree(const WebCore::RenderObject*);	1474 void showTree(const WebCore::RenderObject*);

1474 void showLineTree(const WebCore::RenderObject*);	1475 void showLineTree(const WebCore::RenderObject*);

1475 void showRenderTree(const WebCore::RenderObject* object1);	1476 void showRenderTree(const WebCore::RenderObject* object1);

1476 // We don't make object2 an optional parameter so that showRenderTree	1477 // We don't make object2 an optional parameter so that showRenderTree

1477 // can be called from gdb easily.	1478 // can be called from gdb easily.

1478 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);	1479 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);

1479	1480

1480 #endif	1481 #endif

1481	1482

1482 #endif // RenderObject_h	1483 #endif // RenderObject_h

OLD	NEW