(Reland) Specify --gs-results-bucket arg for chromium.android bots.

(Reland) Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.

Review-Url: https://codereview.chromium.org/2880063002
Cr-Commit-Position: refs/heads/master@{#471595}
Committed: https://chromium.googlesource.com/chromium/src/+/4e3a7c4082bdd25b35036e77b1d8870a47e63e9a

[mikecase (-- gone --), 2017-05-13 14:52:07]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2017-05-13 14:52:08]

original: https://codereview.chromium.org/2868943002/

Relanding with change to b/a/BUILD.gn. Basically, the tests were complaining
that the jinja file did not exist.

"/b/swarm_slave/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py",
line 578, in _ProcessRenderTestResults
    template = jinja2_env.get_template(_JINJA_TEMPLATE_FILENAME)
  File "/b/swarm_slave/w/ir/third_party/jinja2/environment.py", line 812, in
get_template
    return self._load_template(name, self.make_globals(globals))
  File "/b/swarm_slave/w/ir/third_party/jinja2/environment.py", line 774, in
_load_template
    cache_key = self.loader.get_source(self, name)[1]
  File "/b/swarm_slave/w/ir/third_party/jinja2/loaders.py", line 187, in
get_source
    raise TemplateNotFound(template)

[mikecase (-- gone --), 2017-05-13 14:52:37]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 14:52:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-05-13 16:14:40]

On 2017/05/13 14:52:08, mikecase wrote:
> original: https://codereview.chromium.org/2868943002/
> 
> Relanding with change to b/a/BUILD.gn. Basically, the tests were complaining
> that the jinja file did not exist.
> 
>
"/b/swarm_slave/w/ir/build/android/pylib/local/device/local_device_instrumentation_test_run.py",
> line 578, in _ProcessRenderTestResults
>     template = jinja2_env.get_template(_JINJA_TEMPLATE_FILENAME)
>   File "/b/swarm_slave/w/ir/third_party/jinja2/environment.py", line 812, in
> get_template
>     return self._load_template(name, self.make_globals(globals))
>   File "/b/swarm_slave/w/ir/third_party/jinja2/environment.py", line 774, in
> _load_template
>     cache_key = self.loader.get_source(self, name)[1]
>   File "/b/swarm_slave/w/ir/third_party/jinja2/loaders.py", line 187, in
> get_source
>     raise TemplateNotFound(template)

How did this get through the CQ if it failed on swarming bots...?

[jbudorick, 2017-05-13 16:15:42]

lgtm, though I'm interested in how this landed previously.

https://codereview.chromium.org/2880063002/diff/1/build/android/BUILD.gn
File build/android/BUILD.gn (right):

https://codereview.chromium.org/2880063002/diff/1/build/android/BUILD.gn#newc...
build/android/BUILD.gn:117: "pylib/instrumentation/render_test.html.jinja",
future nit: this should be in a subdir of instrumentation/

[commit-bot: I haz the power, 2017-05-13 16:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 16:18:11]

Dry run: This issue passed the CQ dry run.

[mikecase (-- gone --), 2017-05-13 17:10:15]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-13 17:10:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 17:13:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494695415137640, "parent_rev":
"46b2bede398821330e8901c3f95c5ce33b00213d", "commit_rev":
"4e3a7c4082bdd25b35036e77b1d8870a47e63e9a"}

[commit-bot: I haz the power, 2017-05-13 17:14:02]

Description was changed from

==========
(Reland) Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.
==========

to

==========
(Reland) Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.

Review-Url: https://codereview.chromium.org/2880063002
Cr-Commit-Position: refs/heads/master@{#471595}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e3a7c4082bdd25b35036e77b1d8...
==========

[commit-bot: I haz the power, 2017-05-13 17:14:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e3a7c4082bdd25b35036e77b1d8...

[mikecase (-- gone --), 2017-05-13 20:26:59]

mikecase@chromium.org changed reviewers:
+ peconn@chromium.org

[mikecase (-- gone --), 2017-05-13 20:27:00]

woohoo, looks like it worked.

https://storage.cloud.google.com/chromium-result-details/html/chrome_public_t...

Click on...
org.chromium.chrome.browser.ntp.NewTabPageTest

... and see render test results.

[mikecase (-- gone --), 2017-05-13 20:28:46]

https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%...

...got link from chrome_public_test_apk and result_details