Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2880043003: Correct location adjustment in FrameView::ConvertSelfToChild (Closed)

Created:
3 years, 7 months ago by kenrb
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct location adjustment in FrameView::ConvertSelfToChild r471225 removed a negation in the translation of a point between frame coordinate spaces. This CL restores the negation. BUG=721912 Review-Url: https://codereview.chromium.org/2880043003 Cr-Commit-Position: refs/heads/master@{#471506} Committed: https://chromium.googlesource.com/chromium/src/+/204a990c6d1d1cb9a72f50fe1a0639b0c176351d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kenrb
dcheng@: I ran fast layout tests on my machine and they came out clean, so ...
3 years, 7 months ago (2017-05-12 22:34:35 UTC) #4
dcheng
LGTM
3 years, 7 months ago (2017-05-12 23:02:52 UTC) #5
joelhockey
Thanks for picking this up kenrb@. That was my typo. Woops.
3 years, 7 months ago (2017-05-12 23:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880043003/1
3 years, 7 months ago (2017-05-13 00:15:27 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 00:22:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/204a990c6d1d1cb9a72f50fe1a06...

Powered by Google App Engine
This is Rietveld 408576698