Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2880033002: [Merge M59] arg: Handle ARC events in MD Settings (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge M59] arg: Handle ARC events in MD Settings This provides handling ARC events. TURN ON button should be available in case ARC is disabled and unmanaged. Once ARC is enabled TURN ON button is hidden and APPS section is shown. APPS section shows link to ARC Settings app once Settings app appears in the system. While Settings app is not registered tehn link to ARC Settings is hidden. In case user click on ARC Settings link and Settings app is not ready yet (ARC is still booting) then Settings app is started in deferred mode (spinning animation on shelf). Disabling ARC hides APPS section and TURN ON button is active again. BUG=720173 , b/37523579, b/29244888 TEST=Browser test extended, manually on device for managed/unmanaged cases. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=stevenjb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2873853002 Cr-Original-Commit-Position: refs/heads/master@{#471206} Review-Url: https://codereview.chromium.org/2880033002 Cr-Commit-Position: refs/branch-heads/3071@{#540} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0efcdc84378ac11ad36271be860cccdc40292c08

Patch Set 1 #

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880033002/1
3 years, 7 months ago (2017-05-12 22:11:51 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 22:13:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0efcdc84378ac11ad36271be860c...

Powered by Google App Engine
This is Rietveld 408576698