components/viz/frame_sinks/mojo_frame_sink_manager.h - Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/viz/frame_sinks/mojo_frame_sink_manager.h

Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away (Closed)

Patch Set: StrictMock => NiceMock Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/viz/frame_sinks/mojo_frame_sink_manager.h

diff --git a/components/viz/frame_sinks/mojo_frame_sink_manager.h b/components/viz/frame_sinks/mojo_frame_sink_manager.h

index 2539862e624aaa0be2ebb362a2758038c34198f0..07df39e38b4d21ce23239497a137ab0f7f6044c5 100644

--- a/components/viz/frame_sinks/mojo_frame_sink_manager.h

+++ b/components/viz/frame_sinks/mojo_frame_sink_manager.h

@@ -94,6 +94,9 @@ class VIZ_EXPORT MojoFrameSinkManager

// access to a valid pointer for the entirety of their lifetimes.

cc::SurfaceManager manager_;

+ std::unique_ptr<cc::BeginFrameSource> begin_frame_source_;

+ std::unique_ptr<cc::SurfaceDependencyTracker> dependency_tracker_;

// Provides a cc::Display for CreateRootCompositorFrameSink().

DisplayProvider* const display_provider_;