cc/test/begin_frame_source_test.cc - Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/begin_frame_source_test.cc

Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away (Closed)

Patch Set: StrictMock => NiceMock Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/begin_frame_source_test.cc

diff --git a/cc/test/begin_frame_source_test.cc b/cc/test/begin_frame_source_test.cc

index 304f77aa8aa81e6410e116431f2da0c0e19f1694..411250864ca96212beea22d00de8ad41af2225b1 100644

--- a/cc/test/begin_frame_source_test.cc

+++ b/cc/test/begin_frame_source_test.cc

@@ -20,9 +20,8 @@ void MockBeginFrameObserver::AsValueInto(

MockBeginFrameObserver::MockBeginFrameObserver()

: last_begin_frame_args(kDefaultBeginFrameArgs) {

- EXPECT_CALL(*this, LastUsedBeginFrameArgs())

- .Times(::testing::AnyNumber())

- .WillRepeatedly(::testing::ReturnPointee(&last_begin_frame_args));

+ ON_CALL(*this, LastUsedBeginFrameArgs())

+ .WillByDefault(::testing::ReturnPointee(&last_begin_frame_args));

}

MockBeginFrameObserver::~MockBeginFrameObserver() {}