Increase theme version to fix M57->M58 upgrade not migrating themes.

Increase theme version to fix M57->M58 upgrade not migrating themes.

This is what happened:
1. http://crrev.com/2667753004 (Tom's patch) lands, which modifies
ThemeProperties::OverwritableByUserThemeProperty and bumps the theme
version to 46.
2. http://crrev.com/2663363002 (my patch) lands, which does some
unrelated stuff and also bumps the theme version to 47.
3. My patch is merged back to M57. When people install M57 their theme
version goes from 45 to 47, and so their themes are regenerated.
4. M58 comes out, which includes Tom's patch, but the version is still
47 so no one's patches are regenerated. So I essentially "skipped" Tom's
theme version bump.

This patch bumps the version again, in order to regenerate everyone's
themes and get them in sync with Tom's patch.

BUG=652948
Review-Url: https://codereview.chromium.org/2880003003
Cr-Commit-Position: refs/heads/master@{#471606}
Committed: https://chromium.googlesource.com/chromium/src/+/488babf8ae0aad660733d118f28c37169e1ca784

[Bret, 2017-05-12 23:41:01]

Description was changed from

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

The patch that increased the theme version to 47 was merged to M57, but
not the one that increased the theme version to 46. So a migration was
accidentally skipped, breaking a bunch of themes.

BUG=652948
==========

to

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

The patch that increased the theme version to 47 was merged to M57, but
not the one that increased the theme version to 46. So a migration was
accidentally skipped, breaking a bunch of themes.

BUG=652948
==========

[Bret, 2017-05-12 23:41:01]

bsep@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2017-05-13 00:38:11]

lgtm

comment 17 on that bug is a good explanation, but I didn't understand this CL
description. Could you copy over more of the explanation?

And I wonder how we can avoid this in the future. :/

[Bret, 2017-05-13 01:18:14]

Description was changed from

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

The patch that increased the theme version to 47 was merged to M57, but
not the one that increased the theme version to 46. So a migration was
accidentally skipped, breaking a bunch of themes.

BUG=652948
==========

to

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

This is what happened:
1. http://crrev.com/2667753004 (Tom's patch) lands, which modifies
ThemeProperties::OverwritableByUserThemeProperty and bumps the theme
version to 46.
2. http://crrev.com/2663363002 (my patch) lands, which does some
unrelated stuff and also bumps the theme version to 47.
3. My patch is merged back to M57. When people install M57 their theme
version goes from 45 to 47, and so their themes are regenerated.
4. M58 comes out, which includes Tom's patch, but the version is still
47 so no one's patches are regenerated. So I essentially "skipped" Tom's
theme version bump.

This patch bumps the version again, in order to regenerate everyone's
themes and get them in sync with Tom's patch.

BUG=652948
==========

[Bret, 2017-05-13 01:20:10]

On 2017/05/13 00:38:11, Evan Stade wrote:
> lgtm
> 
> comment 17 on that bug is a good explanation, but I didn't understand this CL
> description. Could you copy over more of the explanation?
> 
> And I wonder how we can avoid this in the future. :/

Alright, I copied over most of the comment from the bug.

As for how to avoid this in the future... maybe some kind of presubmit check for
merges to make sure the version is only being incremented by 1?

[Bret, 2017-05-13 01:20:45]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-05-13 01:21:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 02:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:21:07]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-05-13 20:42:08]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-05-13 20:42:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 21:28:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494708128892980, "parent_rev":
"e70e6330e60baf23a2fad22cdacf7ae2cdadee40", "commit_rev":
"488babf8ae0aad660733d118f28c37169e1ca784"}

[commit-bot: I haz the power, 2017-05-13 21:28:15]

Description was changed from

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

This is what happened:
1. http://crrev.com/2667753004 (Tom's patch) lands, which modifies
ThemeProperties::OverwritableByUserThemeProperty and bumps the theme
version to 46.
2. http://crrev.com/2663363002 (my patch) lands, which does some
unrelated stuff and also bumps the theme version to 47.
3. My patch is merged back to M57. When people install M57 their theme
version goes from 45 to 47, and so their themes are regenerated.
4. M58 comes out, which includes Tom's patch, but the version is still
47 so no one's patches are regenerated. So I essentially "skipped" Tom's
theme version bump.

This patch bumps the version again, in order to regenerate everyone's
themes and get them in sync with Tom's patch.

BUG=652948
==========

to

==========
Increase theme version to fix M57->M58 upgrade not migrating themes.

This is what happened:
1. http://crrev.com/2667753004 (Tom's patch) lands, which modifies
ThemeProperties::OverwritableByUserThemeProperty and bumps the theme
version to 46.
2. http://crrev.com/2663363002 (my patch) lands, which does some
unrelated stuff and also bumps the theme version to 47.
3. My patch is merged back to M57. When people install M57 their theme
version goes from 45 to 47, and so their themes are regenerated.
4. M58 comes out, which includes Tom's patch, but the version is still
47 so no one's patches are regenerated. So I essentially "skipped" Tom's
theme version bump.

This patch bumps the version again, in order to regenerate everyone's
themes and get them in sync with Tom's patch.

BUG=652948

Review-Url: https://codereview.chromium.org/2880003003
Cr-Commit-Position: refs/heads/master@{#471606}
Committed:
https://chromium.googlesource.com/chromium/src/+/488babf8ae0aad660733d118f28c...
==========

[commit-bot: I haz the power, 2017-05-13 21:28:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/488babf8ae0aad660733d118f28c...