Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2880003002: supersize: A few fixes for Android+clang builds (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: A few fixes for Android+clang builds BUG=681694 Review-Url: https://codereview.chromium.org/2880003002 Cr-Commit-Position: refs/heads/master@{#471773} Committed: https://chromium.googlesource.com/chromium/src/+/c4e87be4dac0e0780ebe2f5d54d4e5b02dd16e29

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -417 lines) Patch
M tools/binary_size/README.md View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/archive.py View 1 5 chunks +12 lines, -16 lines 0 comments Download
M tools/binary_size/libsupersize/function_signature.py View 2 chunks +22 lines, -7 lines 0 comments Download
M tools/binary_size/libsupersize/function_signature_test.py View 1 chunk +10 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/linker_map_parser.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/nm.py View 3 chunks +19 lines, -10 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive.golden View 2 chunks +48 lines, -47 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_Elf.golden View 1 2 chunks +51 lines, -50 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden View 2 chunks +48 lines, -47 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 2 chunks +33 lines, -31 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 2 chunks +41 lines, -38 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 1 4 chunks +36 lines, -33 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 5 chunks +130 lines, -125 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/mock_toolchain/mock_nm.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/test.map View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/12 20:34:18, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🏌🏻
3 years, 7 months ago (2017-05-12 20:34:37 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-15 13:19:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880003002/20001
3 years, 7 months ago (2017-05-15 15:30:19 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:43:28 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c4e87be4dac0e0780ebe2f5d54d4...

Powered by Google App Engine
This is Rietveld 408576698