Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2879993002: Add const to GamepadEvent functions (Closed)

Created:
3 years, 7 months ago by jkwang
Modified:
3 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add const to GamepadEvent functions Gamepad event functions wll be marked const. Otherise it's not usable when it is passed by const reference. BUG=717246 TEST=Build and test with local gamepad client Review-Url: https://codereview.chromium.org/2879993002 Cr-Commit-Position: refs/heads/master@{#471822} Committed: https://chromium.googlesource.com/chromium/src/+/53276c7f011db2dde25d373ccbd45f2735ceef3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/events/ozone/gamepad/gamepad_event.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
spang
lgtm
3 years, 7 months ago (2017-05-15 17:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879993002/1
3 years, 7 months ago (2017-05-15 17:29:07 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 17:52:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/53276c7f011db2dde25d373ccbd4...

Powered by Google App Engine
This is Rietveld 408576698