Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/vr/android/gvr/gvr_gamepad_data_provider.h

Issue 2879973002: Expose Gamepad API instance for Cardboard button (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/android/vr_shell/vr_shell_gl.cc ('K') | « device/vr/android/gvr/gvr_gamepad_data_fetcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/android/gvr/gvr_gamepad_data_provider.h
diff --git a/device/vr/android/gvr/gvr_gamepad_data_provider.h b/device/vr/android/gvr/gvr_gamepad_data_provider.h
index fcfcf68b94de7da0f70a65f4a15b72bac9c7d340..e500ea3dc2b8a2a7f0f47a8ad8a972d3e1e1dbae 100644
--- a/device/vr/android/gvr/gvr_gamepad_data_provider.h
+++ b/device/vr/android/gvr/gvr_gamepad_data_provider.h
@@ -15,13 +15,14 @@ class GvrGamepadDataFetcher;
// by vr_shell's VrController and consumed by GvrGamepadDataFetcher.
struct GvrGamepadData {
int64_t timestamp;
- gfx::Vector2dF touch_pos;
+ gfx::Vector2dF touch_pos; // controller touch position
billorr1 2017/05/12 18:25:42 nit: comments should be complete sentences
billorr1 2017/05/15 23:04:17 Done.
vr::Quatf orientation;
gfx::Vector3dF accel;
gfx::Vector3dF gyro;
- bool is_touching;
+ bool is_controller_touching;
bool controller_button_pressed;
bool right_handed;
+ bool is_screen_touching; // For cardboard, only the screen touch matters
};
// This class exposes GVR controller data to the gamepad API. Data is
« chrome/browser/android/vr_shell/vr_shell_gl.cc ('K') | « device/vr/android/gvr/gvr_gamepad_data_fetcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698