Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2879903002: blink style: Update BidiTestHarness (Closed)

Created:
3 years, 7 months ago by drott
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
blink-reviews, chromium-reviews, kinuko+watch, leviw+bidiwatch_chromium.org, Youngho Yoo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink style: Update BidiTestHarness bidi_test namespace != blink namespace, fixed by temporarily changing the namespace and running the renaming tool again. BUG=675877 Review-Url: https://codereview.chromium.org/2879903002 Cr-Commit-Position: refs/heads/master@{#471363} Committed: https://chromium.googlesource.com/chromium/src/+/05c3beef96190eae64f7a265d63fe17e380af97d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -185 lines) Patch
M third_party/WebKit/Source/platform/text/BidiResolverTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiTestHarness.h View 4 chunks +182 lines, -179 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
drott
3 years, 7 months ago (2017-05-12 16:32:52 UTC) #2
Nico
Cool, thanks, lgtm.
3 years, 7 months ago (2017-05-12 16:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879903002/1
3 years, 7 months ago (2017-05-12 16:44:45 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 18:00:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05c3beef96190eae64f7a265d63f...

Powered by Google App Engine
This is Rietveld 408576698