Add UseCounter for FTS3 virtual tables in WebSQL.

Add UseCounter for FTS3 virtual tables in WebSQL.

FTS is the only SQLite extension allowed in WebSQL. Turning it off would
reduce the surface area that a polyfill would have to cover when we're
ready to remove WebSQL from the Web platform.

BUG=703507
Review-Url: https://codereview.chromium.org/2879893004
Cr-Commit-Position: refs/heads/master@{#473267}
Committed: https://chromium.googlesource.com/chromium/src/+/ef63607ebb648e211860b3b4604723d4adaac6b1

[pwnall, 2017-05-13 01:46:46]

pwnall@chromium.org changed reviewers:
+ jsbell@chromium.org

[pwnall, 2017-05-13 01:46:46]

michaeln@: PTAL?

[pwnall, 2017-05-13 01:53:34]

pwnall@chromium.org changed reviewers:
+ michaeln@chromium.org
- jsbell@chromium.org

[pwnall, 2017-05-13 01:53:35]

Sorry, the Chromium extension I use acted weirdly.

michaeln@: PTAL?

[pwnall, 2017-05-13 01:53:44]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 01:54:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 03:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 03:33:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaeln, 2017-05-19 00:03:03]

lgtm

[pwnall, 2017-05-19 00:14:56]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-05-19 00:15:07]

On 2017/05/19 00:03:03, michaeln wrote:
> lgtm

Thank you very much!

[commit-bot: I haz the power, 2017-05-19 00:16:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:22:25]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pwnall, 2017-05-19 01:00:32]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[pwnall, 2017-05-19 01:00:48]

pwnall@chromium.org changed reviewers:
+ kinuko@chromium.org

[pwnall, 2017-05-19 01:00:49]

kinuko@chromium.org: Can you please review changes in
third_party/WebKit/Source/core/frame/UseCounter.h?

[commit-bot: I haz the power, 2017-05-19 01:01:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-05-19 01:18:56]

On 2017/05/19 01:00:49, pwnall wrote:
> mailto:kinuko@chromium.org: Can you please review changes in
> third_party/WebKit/Source/core/frame/UseCounter.h?

LGTM

[pwnall, 2017-05-19 01:29:05]

On 2017/05/19 01:18:56, haraken wrote:
> On 2017/05/19 01:00:49, pwnall wrote:
> > mailto:kinuko@chromium.org: Can you please review changes in
> > third_party/WebKit/Source/core/frame/UseCounter.h?
> 
> LGTM

Thank you very much for the quick review!

[pwnall, 2017-05-19 01:29:27]

Description was changed from

==========
Add UseCounter for FTS3 virtual tables in WebSQL.

FTS is the only SQLite extension allowed in WebSQL. Turning it off would
reduce the surface area that a polyfill would have to cover when we're
ready to remove WebSQL from the Web platform.

BUG=703507
==========

to

==========
Add UseCounter for FTS3 virtual tables in WebSQL.

FTS is the only SQLite extension allowed in WebSQL. Turning it off would
reduce the surface area that a polyfill would have to cover when we're
ready to remove WebSQL from the Web platform.

BUG=703507
==========

[pwnall, 2017-05-19 01:29:27]

pwnall@chromium.org changed reviewers:
+ haraken@chromium.org
- kinuko@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:52:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pwnall, 2017-05-19 07:02:06]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-05-19 07:02:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2879893004/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-05-19 07:02:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 07:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:10:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pwnall, 2017-05-19 07:25:23]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-05-19 07:25:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2879893004/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-05-19 07:26:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 11:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 11:10:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pwnall, 2017-05-19 14:07:42]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-19 14:08:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 15:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 15:42:23]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1585
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
  U third_party/WebKit/Source/core/frame/UseCounter.h

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
f6209bfbf07310e33332a7888b0df623891f4463..0dbebf73c631c461555cca17ea88b02e2a00fc79
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1585,6 +1585,7 @@ class CORE_EXPORT UseCounter {
     kPaymentRequestNetworkNameInSupportedMethods = 1976,
     kCrossOriginPropertyAccess = 1977,
     kCrossOriginPropertyAccessFromOpener = 1978,
+    kWebDatabaseCreateDropFTS3Table = 1979,
 
     // Add new features immediately above this line. Don't change assigned
     // numbers of any item, and don't reuse removed slots.

[pwnall, 2017-05-19 16:30:14]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-05-19 16:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2879893004/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-05-19 16:31:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:04:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495211414547890,
"parent_rev": "f06c80209e9760696bdb4f52763115af742d5df1", "commit_rev":
"ef63607ebb648e211860b3b4604723d4adaac6b1"}

[commit-bot: I haz the power, 2017-05-19 19:04:54]

Description was changed from

==========
Add UseCounter for FTS3 virtual tables in WebSQL.

FTS is the only SQLite extension allowed in WebSQL. Turning it off would
reduce the surface area that a polyfill would have to cover when we're
ready to remove WebSQL from the Web platform.

BUG=703507
==========

to

==========
Add UseCounter for FTS3 virtual tables in WebSQL.

FTS is the only SQLite extension allowed in WebSQL. Turning it off would
reduce the surface area that a polyfill would have to cover when we're
ready to remove WebSQL from the Web platform.

BUG=703507

Review-Url: https://codereview.chromium.org/2879893004
Cr-Commit-Position: refs/heads/master@{#473267}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef63607ebb648e211860b3b46047...
==========

[commit-bot: I haz the power, 2017-05-19 19:04:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ef63607ebb648e211860b3b46047...