Restore disk_cache perf tests runnability.

Restore disk_cache perf tests runnability.

They stopped working since the DiskCacheTestBase no longer provides
a MessageLoop as of https://codereview.chromium.org/2839663002.
(Not that I am clear as to how the disk_cache unittests get it
 created, as they don't seem to call NetTestSuite::GetScopedTaskEnvironment()

BUG=

Review-Url: https://codereview.chromium.org/2879893002
Cr-Commit-Position: refs/heads/master@{#471358}
Committed: https://chromium.googlesource.com/chromium/src/+/c19a67fae86a4247b53ccece5bd37eac5afa7edf

[Maks Orlovich, 2017-05-12 15:23:19]

The CQ bit was checked by morlovich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 15:24:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maks Orlovich, 2017-05-12 15:26:15]

morlovich@chromium.org changed reviewers:
+ fdoray@chromium.org, jkarlin@chromium.org

[Maks Orlovich, 2017-05-12 15:26:15]

Not at all sure this is the best approach, kinda at limits
of my knowledge here.

The linked CL definitely had a point about there being too many event-loopy
things :)

[commit-bot: I haz the power, 2017-05-12 15:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 15:37:16]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2017-05-12 15:47:18]

lgtm

[fdoray, 2017-05-12 16:59:32]

lgtm

All net_unittests get their MessageLoop and TaskScheduler from
https://cs.chromium.org/chromium/src/net/test/net_test_suite.cc?l=70 Since
disk_cache perf tests don't run on the CQ, I missed this issue.

[Maks Orlovich, 2017-05-12 17:12:28]

On 2017/05/12 16:59:32, fdoray wrote:
> lgtm
> 
> All net_unittests get their MessageLoop and TaskScheduler from
> https://cs.chromium.org/chromium/src/net/test/net_test_suite.cc?l=70 Since
> disk_cache perf tests don't run on the CQ, I missed this issue.

Ahh, thank you, things make sense now. For some reason I was assuming it
was created in GetScopedTaskEnvironment(), which is of course not the case as
your 
link points out.

[Maks Orlovich, 2017-05-12 17:12:33]

The CQ bit was checked by morlovich@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:13:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 17:48:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494609153165200, "parent_rev":
"fc91a3995bfd7cf39ce78b3b7d6fe69feadb9f34", "commit_rev":
"c19a67fae86a4247b53ccece5bd37eac5afa7edf"}

[commit-bot: I haz the power, 2017-05-12 17:48:32]

Description was changed from

==========
Restore disk_cache perf tests runnability.

They stopped working since the DiskCacheTestBase no longer provides
a MessageLoop as of https://codereview.chromium.org/2839663002.
(Not that I am clear as to how the disk_cache unittests get it
 created, as they don't seem to call NetTestSuite::GetScopedTaskEnvironment()

BUG=
==========

to

==========
Restore disk_cache perf tests runnability.

They stopped working since the DiskCacheTestBase no longer provides
a MessageLoop as of https://codereview.chromium.org/2839663002.
(Not that I am clear as to how the disk_cache unittests get it
 created, as they don't seem to call NetTestSuite::GetScopedTaskEnvironment()

BUG=

Review-Url: https://codereview.chromium.org/2879893002
Cr-Commit-Position: refs/heads/master@{#471358}
Committed:
https://chromium.googlesource.com/chromium/src/+/c19a67fae86a4247b53ccece5bd3...
==========

[commit-bot: I haz the power, 2017-05-12 17:48:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c19a67fae86a4247b53ccece5bd3...