Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2879843002: Reland 1: Enable overriding interface binders for any services running in current process. (Closed)

Created:
3 years, 7 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 1: Enable overriding interface binders for any services running in current process. The original CL was reverted because: VibrationTest.Vibrate times out in browser_side_navigation_content_browsertests on Linux. And the root cause has been fixed by rockot@'s CL https://chromium-review.googlesource.com/c/506598/, so we can reland the original CL without any change now. This CL - holds a 'service name <--> binder registry' map inside service manager client library, at run time it acts as a global variable in any process linking with service manager client library. - lets ServiceContext::OnBindInterface() use the global map to intercept requests before dispatching them to target Services, that is to say, such interception may happen for any Services running in current process. - exposes {SetGlobalBinder,ClearGlobalBinders}ForTesting to set/clear binders in the global map. - adds a VibrationTest browser test to show the usage of the new infra described above. BUG=717377, 717378 TEST=content_browsertests TBR=rockot@chromium.org,jam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2859343003 Cr-Original-Commit-Position: refs/heads/master@{#471216} Committed: https://chromium.googlesource.com/chromium/src/+/d25e37df0f08a754fbc11041451a5ce7ca7d043d Review-Url: https://codereview.chromium.org/2879843002 Cr-Commit-Position: refs/heads/master@{#473120} Committed: https://chromium.googlesource.com/chromium/src/+/31c48e20cf23dcc484e259d339cbc380d6f162b1

Patch Set 1 : Identical with original CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -11 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
A content/browser/vibration_browsertest.cc View 1 chunk +90 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.h View 2 chunks +8 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/interface_binder.h View 2 chunks +8 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/interface_binder.cc View 2 chunks +27 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 2 chunks +15 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/service_context.cc View 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (24 generated)
leonhsl(Using Gerrit)
Thanks to Ken's CL fixing the root cause, we can reland this CL now, I'd ...
3 years, 7 months ago (2017-05-19 05:26:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879843002/60001
3 years, 7 months ago (2017-05-19 05:28:50 UTC) #24
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-19 05:28:59 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 07:52:33 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31c48e20cf23dcc484e259d339cb...

Powered by Google App Engine
This is Rietveld 408576698