Merge "DevTools: Fix a regression that double-clicking an item in the Network tab doesn't open the …

Merge "DevTools: Fix a regression that double-clicking an item in the Network tab doesn't open the item in a new tab." to M59

ViewportDataGrid._update() has the following code:
    tBody.insertBefore(element, previousElement.nextSibling);
where |previousElement.nextSibling| can be |element|.

The code did nothing before [1], but we remove |element| from |tBody| and add it
to |tBody| again after [1]. Because the code is executed in 'mousedown' event
handler, 'dblclick' event for |element| wasn't dispatched.

This CL updates ViewportDataGrid so that it skips to call insertBefore() if
|element| is |previousElement.nextSibling|.

[1] https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b8eb0392da651

BUG=716583
Review-Url: https://codereview.chromium.org/2869643002
Cr-Original-Commit-Position: refs/heads/master@{#470833}
Review-Url: https://codereview.chromium.org/2879833002 .
Cr-Commit-Position: refs/branch-heads/3071@{#526}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/40c9f80c84d855a837d0be558173f8a27679d110

[tkent, 2017-05-12 08:49:47]

Description was changed from

==========
Merge "DevTools: Fix a regression that double-clicking an item in the Network
tab doesn't open the item in a new tab." to M59

ViewportDataGrid._update() has the following code:
    tBody.insertBefore(element, previousElement.nextSibling);
where |previousElement.nextSibling| can be |element|.

The code did nothing before [1], but we remove |element| from |tBody| and add it
to |tBody| again after [1]. Because the code is executed in 'mousedown' event
handler, 'dblclick' event for |element| wasn't dispatched.

This CL updates ViewportDataGrid so that it skips to call insertBefore() if
|element| is |previousElement.nextSibling|.

[1]
https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b...

BUG=716583

Review-Url: https://codereview.chromium.org/2869643002
Cr-Commit-Position: refs/heads/master@{#470833}
(cherry picked from commit 6d44fde7f95c979cd78698142389b6fe4fa8916f)
==========

to

==========
Merge "DevTools: Fix a regression that double-clicking an item in the Network
tab doesn't open the item in a new tab." to M59

ViewportDataGrid._update() has the following code:
    tBody.insertBefore(element, previousElement.nextSibling);
where |previousElement.nextSibling| can be |element|.

The code did nothing before [1], but we remove |element| from |tBody| and add it
to |tBody| again after [1]. Because the code is executed in 'mousedown' event
handler, 'dblclick' event for |element| wasn't dispatched.

This CL updates ViewportDataGrid so that it skips to call insertBefore() if
|element| is |previousElement.nextSibling|.

[1]
https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b...

BUG=716583

Review-Url: https://codereview.chromium.org/2869643002
Cr-Original-Commit-Position: refs/heads/master@{#470833}
Review-Url: https://codereview.chromium.org/2879833002 .
Cr-Commit-Position: refs/branch-heads/3071@{#526}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/40c9f80c84d855a837d0be558173...
==========

[tkent, 2017-05-12 08:49:48]

Committed patchset #1 (id:1) manually as
40c9f80c84d855a837d0be558173f8a27679d110 (tree was closed).