Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2879793003: Disable stack trace during MetricsServiceBrowserTest.OOMRenderers (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
Reviewers:
Nico, Will Harris
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable stack trace during MetricsServiceBrowserTest.OOMRenderers DbgHelp is unreliable in low-memory sistuations. After intentionally exhausting the heap, the test would hang in DbgHelp's SymFromAddr(). BUG=692564 Review-Url: https://codereview.chromium.org/2879793003 Cr-Commit-Position: refs/heads/master@{#471392} Committed: https://chromium.googlesource.com/chromium/src/+/59665042f159cb7d4deb3b26e34340461d9d1e65

Patch Set 1 #

Patch Set 2 : Add bug reference #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
hans
Please take a look.
3 years, 7 months ago (2017-05-12 16:42:08 UTC) #2
Will Harris
https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/metrics_service_browsertest.cc File chrome/browser/metrics/metrics_service_browsertest.cc (right): https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/metrics_service_browsertest.cc#newcode202 chrome/browser/metrics/metrics_service_browsertest.cc:202: service_manager::switches::kDisableInProcessStackTraces); I'm not too familiar with this switch, but ...
3 years, 7 months ago (2017-05-12 16:46:33 UTC) #3
Nico
lgtm
3 years, 7 months ago (2017-05-12 16:46:33 UTC) #4
hans
On 2017/05/12 16:46:33, Will Harris wrote: > https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/metrics_service_browsertest.cc > File chrome/browser/metrics/metrics_service_browsertest.cc (right): > > https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/metrics_service_browsertest.cc#newcode202 ...
3 years, 7 months ago (2017-05-12 16:51:10 UTC) #5
Will Harris
okay that makes sense. lgtm
3 years, 7 months ago (2017-05-12 16:54:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879793003/20001
3 years, 7 months ago (2017-05-12 17:00:28 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 18:56:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59665042f159cb7d4deb3b26e343...

Powered by Google App Engine
This is Rietveld 408576698