Disable stack trace during MetricsServiceBrowserTest.OOMRenderers

Disable stack trace during MetricsServiceBrowserTest.OOMRenderers

DbgHelp is unreliable in low-memory sistuations. After intentionally exhausting
the heap, the test would hang in DbgHelp's SymFromAddr().

BUG=692564
Review-Url: https://codereview.chromium.org/2879793003
Cr-Commit-Position: refs/heads/master@{#471392}
Committed: https://chromium.googlesource.com/chromium/src/+/59665042f159cb7d4deb3b26e34340461d9d1e65

[hans, 2017-05-12 16:42:08]

hans@chromium.org changed reviewers:
+ thakis@chromium.org, wfh@chromium.org

[hans, 2017-05-12 16:42:08]

Please take a look.

[Will Harris, 2017-05-12 16:46:33]

https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/metrics_service_browsertest.cc (right):

https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/metrics_service_browsertest.cc:202:
service_manager::switches::kDisableInProcessStackTraces);
I'm not too familiar with this switch, but does it work this late into process
initialization i.e. this isn't too late?

[Nico, 2017-05-12 16:46:33]

lgtm

[hans, 2017-05-12 16:51:10]

On 2017/05/12 16:46:33, Will Harris wrote:
>
https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/...
> File chrome/browser/metrics/metrics_service_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2879793003/diff/20001/chrome/browser/metrics/...
> chrome/browser/metrics/metrics_service_browsertest.cc:202:
> service_manager::switches::kDisableInProcessStackTraces);
> I'm not too familiar with this switch, but does it work this late into process
> initialization i.e. this isn't too late?

Yes, it worked in my testing at least -- there is no stack trace, and the test
passes.

It might be that it would be too late to disable it for the browser process here
(I'm not even sure the flag even applies to the browser process), but the flag
gets forwarded to the renderer, which hasn't launched yet at this point, and
that's the important process here.

[Will Harris, 2017-05-12 16:54:48]

okay that makes sense. lgtm

[hans, 2017-05-12 16:59:47]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:00:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:56:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494608387249230,
"parent_rev": "0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be", "commit_rev":
"59665042f159cb7d4deb3b26e34340461d9d1e65"}

[commit-bot: I haz the power, 2017-05-12 18:56:25]

Description was changed from

==========
Disable stack trace during MetricsServiceBrowserTest.OOMRenderers

DbgHelp is unreliable in low-memory sistuations. After intentionally exhausting
the heap, the test would hang in DbgHelp's SymFromAddr().

BUG=692564
==========

to

==========
Disable stack trace during MetricsServiceBrowserTest.OOMRenderers

DbgHelp is unreliable in low-memory sistuations. After intentionally exhausting
the heap, the test would hang in DbgHelp's SymFromAddr().

BUG=692564

Review-Url: https://codereview.chromium.org/2879793003
Cr-Commit-Position: refs/heads/master@{#471392}
Committed:
https://chromium.googlesource.com/chromium/src/+/59665042f159cb7d4deb3b26e343...
==========

[commit-bot: I haz the power, 2017-05-12 18:56:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59665042f159cb7d4deb3b26e343...