Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2879783003: PDF: Tweak font-size and colors to more closely match other MD WebUI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by tsergeant
Modified:
1 week, 1 day ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, dcheng, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Tweak font-size and colors to more closely match other MD WebUI MD PDF was written before we had a firm style for MD WebUI, both in terms of visual style (typography, etc) and code style. This CL updates MD PDF with a few changes to bring it in line with more recent changes. In particular, * Load the MD version of text_defaults.css, changing how fonts are applied across the page. * Update default text to 13px paper-grey-900. This only affects the bookmarks dropdown and error/password dialogs. * Tweak padding in the main toolbar. * Remove usage of paper-material. * Change how CSS variables are applied to the page (using a custom-style block). BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2879783003 Cr-Commit-Position: refs/heads/master@{#472020} Committed: https://chromium.googlesource.com/chromium/src/+/d411c5d512aa58ebabaf8eb4f6594285d7bea86e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -40 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/pdf/elements/shared-icon-style.css View 1 chunk +0 lines, -15 lines 0 comments Download
A chrome/browser/resources/pdf/elements/shared-vars.html View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.css View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.css View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.css View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:  win_chromium_rel_ng   win_chromium_x64_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   ios-device-xcode-clang   ios-device   ios-simulator   linux_chromium_tsan_rel_ng   closure_compilation   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   cast_shell_android   linux_android_rel_ng   android_n5x_swarming_rel   android_cronet   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   ios-simulator   closure_compilation   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromium_presubmit   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (9 generated)
tsergeant
I started looking into cr-dialog stuff, and found a grab-bag of other things that I ...
1 week, 5 days ago (2017-05-12 04:32:36 UTC) #5
Dan Beam
there are many things i could say about this code that is a little special ...
1 week, 1 day ago (2017-05-16 03:08:00 UTC) #8
tsergeant
Thanks for reviewing!
1 week, 1 day ago (2017-05-16 03:38:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879783003/1
1 week, 1 day ago (2017-05-16 03:38:52 UTC) #11
commit-bot: I haz the power
1 week, 1 day ago (2017-05-16 05:38:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d411c5d512aa58ebabaf8eb4f659...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06