Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2879783002: Compute topologically sorted library cycles. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute topologically sorted library cycles. In following CLs we will compile (or load already compiled) kernels for each cycle and compile following cycles against them. R=paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/25e8941cc7345d9b8e81f39902b111b52962a02d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes for review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -35 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 1 5 chunks +85 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +0 lines, -10 lines 0 comments Download
A pkg/front_end/test/src/incremental/file_state_test.dart View 1 1 chunk +155 lines, -0 lines 0 comments Download
A pkg/front_end/test/src/incremental/test_all.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 7 months ago (2017-05-12 03:37:08 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2879783002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart File pkg/front_end/lib/src/incremental/file_state.dart (right): https://codereview.chromium.org/2879783002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart#newcode48 pkg/front_end/lib/src/incremental/file_state.dart:48: /// The list of files this file exports. ...
3 years, 7 months ago (2017-05-12 14:30:43 UTC) #2
scheglov
https://codereview.chromium.org/2879783002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart File pkg/front_end/lib/src/incremental/file_state.dart (right): https://codereview.chromium.org/2879783002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart#newcode48 pkg/front_end/lib/src/incremental/file_state.dart:48: /// The list of files this file exports. On ...
3 years, 7 months ago (2017-05-12 15:40:58 UTC) #3
scheglov
3 years, 7 months ago (2017-05-12 15:41:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25e8941cc7345d9b8e81f39902b111b52962a02d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698