pkg/front_end/lib/src/incremental_kernel_generator_impl.dart - Issue 2879783002: Compute topologically sorted library cycles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2879783002: Compute topologically sorted library cycles. (Closed)

Patch Set: Fixes for review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

diff --git a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

index c19ed2adb848f614a596db84367d2c7ace247170..f2bdc118182ad52af5c5062c38a4186cf9add2e7 100644

--- a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

+++ b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

@@ -125,13 +125,3 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {

_invalidatedFiles.clear();

}

-///// Clears canonical names of [NamedNode] references.

-//class _ClearCanonicalNamesVisitor extends Visitor {

-// defaultNode(Node node) {

-// if (node is NamedNode) {

-// node.reference.canonicalName = null;

-// }

-// node.visitChildren(this);

-// }

-//}