third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

index 0b386a967d629a4791789bac2fa34c01e977ba16..d8056ae69e40194bdf9fdb55b9627aaf8768753c 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

@@ -63,7 +63,7 @@ class WaitUntilObserver::ThenFunction final : public ScriptFunction {

ScriptValue Call(ScriptValue value) override {

DCHECK(observer_);

- ASSERT(resolve_type_ == kFulfilled || resolve_type_ == kRejected);

+ DCHECK(resolve_type_ == kFulfilled || resolve_type_ == kRejected);

if (resolve_type_ == kRejected) {

observer_->OnPromiseRejected();

value =

@@ -158,7 +158,7 @@ void WaitUntilObserver::IncrementPendingActivity() {

}

void WaitUntilObserver::DecrementPendingActivity() {

- ASSERT(pending_activity_ > 0);

+ DCHECK_GT(pending_activity_, 0);

if (!execution_context_ ||

(event_dispatch_state_ != EventDispatchState::kFailed &&

--pending_activity_))