third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc

diff --git a/third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc b/third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc

index 3d867e54f3c0d13b2398ba9a324d6ab44809ef0d..fa4ee69fd232c0143c1c9d1d82dd4dcf86a5ed5d 100644

--- a/third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc

+++ b/third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc

@@ -240,7 +240,7 @@ namespace double_conversion {

// is a fixed-point number, with binary point at bit 'point'.

if (-exponent <= 64) {

// One 64 bit number is sufficient.

- DCHECK(fractionals >> 56 == 0);

+ DCHECK_EQ(fractionals >> 56, 0UL);

int point = -exponent;

for (int i = 0; i < fractional_count; ++i) {

if (fractionals == 0) break;