Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2879763002: Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking We can't have the [data] and [source] getters typed as Object. This causes it to appear that all DOM types are instantiated. I have modelled the annotations after the same getters from MessageEvent. TBR=jacobr@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ca3d90c4cd7155709a7836d0830b1f712925a8cd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +15 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
Reduces swarm by 70k.
3 years, 7 months ago (2017-05-12 02:30:58 UTC) #2
sra1
Committed patchset #1 (id:1) manually as ca3d90c4cd7155709a7836d0830b1f712925a8cd (presubmit successful).
3 years, 7 months ago (2017-05-12 02:31:32 UTC) #4
Jacob
3 years, 7 months ago (2017-05-12 02:41:36 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2879763002/diff/1/tools/dom/scripts/dartmetad...
File tools/dom/scripts/dartmetadata.py (right):

https://codereview.chromium.org/2879763002/diff/1/tools/dom/scripts/dartmetad...
tools/dom/scripts/dartmetadata.py:163: # the JavaScript wire type into a Dart
type.
Yeah this is most likely busted as is.

Powered by Google App Engine
This is Rietveld 408576698