Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 2879763002: Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/dartmetadata.py
diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py
index f278864aa3b231e238dfa1e5d746d1738b35316d..7ec8331df2b54288efb4b619dbdb212c4d8801d2 100644
--- a/tools/dom/scripts/dartmetadata.py
+++ b/tools/dom/scripts/dartmetadata.py
@@ -158,6 +158,21 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('EventTarget|=Object')",
],
+ # TODO(sra): Investigate how ExtendableMessageEvent.data is different from
+ # MessageEvent.data. It might be necessary to put in a method to translate
+ # the JavaScript wire type into a Dart type.
Jacob 2017/05/12 02:41:36 Yeah this is most likely busted as is.
+ 'ExtendableMessageEvent.data': [
+ "@annotation_Creates_SerializedScriptValue",
+ "@annotation_Returns_SerializedScriptValue",
+ ],
+
+ # TODO(sra): We could determine the following by parsing the compound IDL
+ # type.
+ 'ExtendableMessageEvent.source': [
+ "@Creates('Client|_ServiceWorker|MessagePort')",
+ "@Returns('Client|_ServiceWorker|MessagePort|Null')",
+ ],
+
'File.lastModifiedDate': [
"@Creates('Null')", # JS date object.
],
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698