Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 287973002: Revert 270430 "Retry: Change Skia DEPS to pull from googlesource..." (Closed)

Created:
6 years, 7 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 7 months ago
Reviewers:
borenet
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 270430 "Retry: Change Skia DEPS to pull from googlesource..." > Retry: Change Skia DEPS to pull from googlesource (git) > > Original CL: https://codereview.chromium.org/275893002/ caused "gclient revert" failures after the initial sync because third_party/skia was still under svn control. This one is back with a new twist: it's uploaded from svn, and I "svn rm"d the third_party/skia directory. I'll have to dcommit it since Rietveld doesn't know about the directory remove. > > R=jiayl@chromium.org, reed@google.com > > Review URL: https://codereview.chromium.org/289603002 TBR=borenet@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M trunk/src/DEPS View 3 chunks +11 lines, -3 lines 0 comments Download
A + trunk/src/third_party/skia/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/skia/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/skia/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 7 months ago (2014-05-14 20:02:54 UTC) #1
borenet
LGTM
6 years, 7 months ago (2014-05-14 20:03:18 UTC) #2
vrk (LEFT CHROMIUM)
6 years, 7 months ago (2014-05-14 20:03:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r270459 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698