Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 289603002: Retry: Change Skia DEPS to pull from googlesource (git) (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
CC:
chromium-reviews, reed1, robertphillips
Base URL:
https://src.chromium.org/svn/trunk/src/
Visibility:
Public.

Description

Retry: Change Skia DEPS to pull from googlesource (git) Original CL: https://codereview.chromium.org/275893002/ caused "gclient revert" failures after the initial sync because third_party/skia was still under svn control. This one is back with a new twist: it's uploaded from svn, and I "svn rm"d the third_party/skia directory. I'll have to dcommit it since Rietveld doesn't know about the directory remove. R=jiayl@chromium.org, reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270430

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -45 lines) Patch
M DEPS View 1 2 3 chunks +3 lines, -11 lines 0 comments Download
D third_party/skia/LICENSE View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/skia/OWNERS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/skia/README.chromium View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
6 years, 7 months ago (2014-05-14 02:02:12 UTC) #1
jiayl
On 2014/05/14 02:02:12, borenet wrote: What verification has been done? Are we sure it will ...
6 years, 7 months ago (2014-05-14 16:52:05 UTC) #2
jiayl
On 2014/05/14 16:52:05, jiayl wrote: > On 2014/05/14 02:02:12, borenet wrote: > > What verification ...
6 years, 7 months ago (2014-05-14 16:54:17 UTC) #3
borenet
On 2014/05/14 16:52:05, jiayl wrote: > On 2014/05/14 02:02:12, borenet wrote: > > What verification ...
6 years, 7 months ago (2014-05-14 16:56:15 UTC) #4
huangs
LGTM
6 years, 7 months ago (2014-05-14 17:05:48 UTC) #5
jiayl
lgtm
6 years, 7 months ago (2014-05-14 17:06:12 UTC) #6
reed1
lgtm
6 years, 7 months ago (2014-05-14 17:15:47 UTC) #7
borenet
6 years, 7 months ago (2014-05-14 17:40:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r270430.

Powered by Google App Engine
This is Rietveld 408576698