Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2879723003: Revert of gpu: guarantee to match pending GBM buffer request to actual GBM handle (Closed)

Created:
3 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: guarantee to match pending GBM buffer request to actual GBM handle (patchset #3 id:40001 of https://codereview.chromium.org/2878573002/ ) Reason for revert: DCHECK triggers on tests in GpuProcessHost::CreateGpuMemoryBuffer Original issue's description: > gpu: guarantee to match pending GBM buffer request to actual GBM handle > > This CL makes |gpu_proecess_host| select the right callback by GMB id, not > brute-force FIFO. It becomes more stable code for the future change. > e.g. reordering IPC for priotization > > BUG=475633, 629521 > > Review-Url: https://codereview.chromium.org/2878573002 > Cr-Commit-Position: refs/heads/master@{#471116} > Committed: https://chromium.googlesource.com/chromium/src/+/e17baa4e12ee81c41668d7ef07e08a1a8e096dc6 TBR=piman@chromium.org,dongseong.hwang@chromium.org,dongseong.hwang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475633, 629521 Review-Url: https://codereview.chromium.org/2879723003 Cr-Commit-Position: refs/heads/master@{#471272} Committed: https://chromium.googlesource.com/chromium/src/+/136aeef2b359782047037a3147c8b2a8af6aceda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
Created Revert of gpu: guarantee to match pending GBM buffer request to actual GBM handle
3 years, 7 months ago (2017-05-12 11:33:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879723003/1
3 years, 7 months ago (2017-05-12 11:34:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/136aeef2b359782047037a3147c8b2a8af6aceda
3 years, 7 months ago (2017-05-12 11:34:52 UTC) #6
dshwang
On 2017/05/12 11:34:52, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 7 months ago (2017-05-12 21:37:25 UTC) #7
dshwang
3 years, 7 months ago (2017-05-15 23:27:13 UTC) #8
Message was sent while issue was closed.
On 2017/05/12 21:37:25, dshwang wrote:
> On 2017/05/12 11:34:52, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/136aeef2b359782047037a3147c8...
> 
> hi jochen, thank you for revert. Could you share stack trace or use case in
> which the DCHECK failed?

Hi Jochen, could you point out what test failed? thank you.

Powered by Google App Engine
This is Rietveld 408576698