Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 2879723002: Remove android_webview_apk and android_webview_test_apk (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, sgurun-gerrit only
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_webview_apk and android_webview_test_apk This CL removes both android_webview_apk and android_webview_test_apk build targets as we are deprecating those two names. Please refer the crbug for more info, and the new target names are webview_instrumentation_apk and webview_instrumentation_test_apk correspondingly. New build names are WebViewInstrumentation.apk and WebViewInstrumentationTest.apk BUG=701938 Review-Url: https://codereview.chromium.org/2879723002 Cr-Commit-Position: refs/heads/master@{#472276} Committed: https://chromium.googlesource.com/chromium/src/+/23a57a1539f1ebf22f42d01a2978ed5b67654201

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -184 lines) Patch
M android_webview/test/BUILD.gn View 2 chunks +159 lines, -184 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Shimi Zhang
torne@, PTAL, thanks!
3 years, 7 months ago (2017-05-16 17:18:14 UTC) #6
Torne
LGTM
3 years, 7 months ago (2017-05-16 17:45:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879723002/20001
3 years, 7 months ago (2017-05-16 20:58:09 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 01:05:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23a57a1539f1ebf22f42d01a2978...

Powered by Google App Engine
This is Rietveld 408576698