Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issue 2879693002: Skip failing LayoutTest. (Closed)

Created:
3 years, 7 months ago by apacible
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip failing LayoutTest. Still failing after updating the expectation to Failure Pass Timeout. Skipping the test for now. See crbug for more details. BUG=720511 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2879693002 . Cr-Commit-Position: refs/heads/master@{#471110} Committed: https://chromium.googlesource.com/chromium/src/+/c3446d5d8214478acc171910990e3562eb0bee50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
lgtm, but I wonder if the old CL just took a while to take. I ...
3 years, 7 months ago (2017-05-11 22:53:30 UTC) #5
Nico
On the third hand, it failed on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452295 too and that started 2h ago. So ...
3 years, 7 months ago (2017-05-11 22:59:38 UTC) #6
Nico
On the third hand, it failed on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452295 too and that started 2h ago. So ...
3 years, 7 months ago (2017-05-11 22:59:39 UTC) #7
apacible
3 years, 7 months ago (2017-05-11 23:08:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3446d5d8214478acc171910990e3562eb0bee50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698