Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2879683004: Initialize did_run_updater_ in browser startup. (Closed)

Created:
3 years, 7 months ago by Will Harris
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize did_run_updater_ in browser startup. This was mistakenly removed in crrev.com/2621363002. BUG=721562 Review-Url: https://codereview.chromium.org/2879683004 Cr-Commit-Position: refs/heads/master@{#471121} Committed: https://chromium.googlesource.com/chromium/src/+/0762cfd079b91ff195345470c6253e9605716e0c

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Will Harris
PTAL. let me know if you want me to raise a bug.
3 years, 7 months ago (2017-05-11 22:16:38 UTC) #5
Nico
lgtm, but please file a bug for having test coverage for this, and put that ...
3 years, 7 months ago (2017-05-11 22:34:40 UTC) #6
Will Harris
thanks for speedy review. https://codereview.chromium.org/2879683004/diff/1/chrome/browser/chrome_browser_main_win.cc File chrome/browser/chrome_browser_main_win.cc (right): https://codereview.chromium.org/2879683004/diff/1/chrome/browser/chrome_browser_main_win.cc#newcode382 chrome/browser/chrome_browser_main_win.cc:382: InitializeChromeElf(); On 2017/05/11 22:34:40, Nico ...
3 years, 7 months ago (2017-05-11 22:46:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879683004/20001
3 years, 7 months ago (2017-05-11 22:47:51 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:41:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0762cfd079b91ff195345470c625...

Powered by Google App Engine
This is Rietveld 408576698