Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2879673003: build: Allow ICF on architectures other than x86 and x64. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Allow ICF on architectures other than x86 and x64. The ICF bug only affects x86 and x64, so we can still use ICF when targeting other architectures. BUG=721779 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2879673003 Cr-Commit-Position: refs/heads/master@{#471459} Committed: https://chromium.googlesource.com/chromium/src/+/03a5248bcceec84a9d29b1ed3ada8bc5fd23d3c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
pcc1
3 years, 7 months ago (2017-05-12 18:03:50 UTC) #1
Nico
lgtm
3 years, 7 months ago (2017-05-12 19:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879673003/1
3 years, 7 months ago (2017-05-12 19:25:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369629)
3 years, 7 months ago (2017-05-12 20:05:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879673003/1
3 years, 7 months ago (2017-05-12 20:10:42 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 22:14:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03a5248bcceec84a9d29b1ed3ada...

Powered by Google App Engine
This is Rietveld 408576698