Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2879643002: Remove duplicate service workers "appcache" test (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service workers "appcache" test The upstream version of this test differs only in its improved "clean up" logic. All "resource" files are identical. BUG=688116, 410665 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2879643002 Cr-Commit-Position: refs/heads/master@{#471327} Committed: https://chromium.googlesource.com/chromium/src/+/a21ee88b483cadbf94d50598dcc813eb698d1e64

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
mike3
Hi Mek, The difference between Chromium's version and WPT's version of this test is pretty ...
3 years, 7 months ago (2017-05-11 16:37:18 UTC) #1
falken
lgtm with BUG=688116, 410665
3 years, 7 months ago (2017-05-12 04:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879643002/1
3 years, 7 months ago (2017-05-12 15:20:16 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:34:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a21ee88b483cadbf94d50598dcc8...

Powered by Google App Engine
This is Rietveld 408576698